Add an exe extension to windows binary during cross build.#2362
Merged
thaJeztah merged 1 commit intodocker:masterfrom Mar 3, 2020
Merged
Add an exe extension to windows binary during cross build.#2362thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
Member
|
Didn't check yet if it fixes #2359 (perhaps there's another issue), but this change itself looks good to me |
Contributor
Author
|
@thaJeztah just checked with @mat007 and adding the |
thaJeztah
approved these changes
Mar 3, 2020
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
whoops, forgot about this one
LGTM, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fix #2359 "make -f docker.Makefile binary-windows after build download to windows, but can't execute."
The
exeextension was indeed missing, just added it in the cross compiling windows script.- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)